Skip to content

Marketplace Issue: Non-extendable method usage violation #7912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2025
Merged

Marketplace Issue: Non-extendable method usage violation #7912

merged 2 commits into from
Oct 10, 2025

Conversation

@LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Sep 29, 2025

Address Marketplace Issue:

Non-extendable method FileChooserDescriptor.isFileSelectable(...) is overridden by UseExistingBazelWorkspaceOption$1.isFileSelectable(...). This method is marked with @ApiStatus.NonExtendable annotation, which indicates that the method is not supposed to be overridden by client code. See documentation of the @ApiStatus.NonExtendable for more info.

@LeFrosch LeFrosch marked this pull request as ready for review September 29, 2025 15:14
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Sep 29, 2025
ujohnny
ujohnny requested changes Sep 29, 2025
View reviewed changes
base/src/com/google/idea/blaze/base/wizard2/UseExistingBazelWorkspaceOption.java Outdated
.withDescription("Select the directory of the workspace you want to use.")
.withFileFilter(UseExistingBazelWorkspaceOption::isWorkspaceRoot);

descriptor = new FileChooserDescriptor(descriptor) {
Copy link
Collaborator

@ujohnny ujohnny Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation

var descriptor = ...
descriptor = foo(descriptor)

looks a bit odd. let's make a separate variable?

@LeFrosch LeFrosch merged commit 18d1ef1 into bazelbuild:master Oct 10, 2025
3 checks passed
@LeFrosch LeFrosch deleted the pull/2f4cda189e962497429f4545cf784ea0215ca10b branch October 10, 2025 14:39
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Bazel IntelliJ Plugin Oct 10, 2025
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ujohnny ujohnny ujohnny approved these changes

@mai93 mai93 Awaiting requested review from mai93 mai93 is a code owner

@agluszak agluszak Awaiting requested review from agluszak agluszak is a code owner

Assignees

@ujohnny ujohnny

@sellophane sellophane

@iliakondratev iliakondratev

Labels

product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin

Projects

Bazel IntelliJ Plugin
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LeFrosch @ujohnny @sellophane @iliakondratev