Skip to content

Commit

Permalink
Remove _xcrunwrapper (#2032)
Browse files Browse the repository at this point in the history
  • Loading branch information
keith authored Aug 11, 2023
1 parent 53d8764 commit 3941087
Showing 1 changed file with 1 addition and 16 deletions.
17 changes: 1 addition & 16 deletions apple/internal/rule_factory.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -146,22 +146,7 @@ def _link_multi_arch_binary_attrs(*, cfg = apple_common.multi_arch_split):
Args:
cfg: Bazel split transition to use on attrs.
"""
return dicts.add(
_common_linking_api_attrs(cfg = cfg),
{
# xcrunwrapper is no longer used by rules_apple, but the underlying implementation of
# apple_common.link_multi_arch_binary and j2objc_dead_code_pruner require this attribute.
# See CompilationSupport.java:
# - `registerJ2ObjcDeadCodeRemovalActions()`
# - `registerLinkActions()` --> `registerBinaryStripAction()`
# TODO(b/117932394): Remove this attribute once Bazel no longer uses xcrunwrapper.
"_xcrunwrapper": attr.label(
cfg = "exec",
executable = True,
default = Label("@bazel_tools//tools/objc:xcrunwrapper"),
),
},
)
return _common_linking_api_attrs(cfg = cfg)

# Needed for the J2ObjC processing code that already exists in the implementation of
# apple_common.link_multi_arch_binary.
Expand Down

0 comments on commit 3941087

Please sign in to comment.