Skip to content

Commit

Permalink
Dont override destination-timeout in xctestrun runner (#2572)
Browse files Browse the repository at this point in the history
The default value for this is `30`. We probably shouldn't override this
by default. I will follow up this PR by allowing the
`-destination-timeout` to be set via the `ios_xctestrun_runner` rule
**and** via the `--test_env`

```
man xcodebuild

-destination-timeout timeout
  Use the specified timeout when searching for a destination device. The default is 30 seconds.

```
  • Loading branch information
luispadron authored Oct 29, 2024
1 parent 942c213 commit fe9a83f
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,6 @@ if [[ "$should_use_xcodebuild" == true ]]; then
fi

args=(
-destination-timeout 15 \
-xctestrun "$xctestrun_file" \
)

Expand Down

0 comments on commit fe9a83f

Please sign in to comment.