Fix race condition between xcodebuild and symlink action for test XCFramework #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins and
thii
as code owners
keith
referenced
this pull request
Oct 13, 2022
…ramework This change updates when modulemap files are generated XCFramework with static libraries. Previously, modulemap were generated after the XCFramework bundle was created with xcodebuild. Now, it's being included as part of the headers directory. Additionally, this change adopts the intermediates module ahead of a rule migration to test/starlark_tests/. PiperOrigin-RevId: 465638790
brentleyjones
approved these changes
Oct 13, 2022
thii
approved these changes
Oct 14, 2022
keith
force-pushed
the
ks/fix-race-condition-between-xcodebuild-and-symlink-action-for-test-xcframework
branch
from
aee02c1
to
5d08491
Compare
keith
force-pushed
the
ks/fix-race-condition-between-xcodebuild-and-symlink-action-for-test-xcframework
branch
2 times, most recently
from
5094d38
to
0dac0db
Compare
…ramework This change updates when modulemap files are generated XCFramework with static libraries. Previously, modulemap were generated after the XCFramework bundle was created with xcodebuild. Now, it's being included as part of the headers directory. Additionally, this change adopts the intermediates module ahead of a rule migration to test/starlark_tests/. PiperOrigin-RevId: 465638790 (cherry picked from commit e3cd464)
I redid this by copying the dynamic fw impl again and changing the small pieces needed to make it static instead
keith
force-pushed
the
ks/fix-race-condition-between-xcodebuild-and-symlink-action-for-test-xcframework
branch
from
008f741
to
f0124dd
Compare
keith
deleted the
ks/fix-race-condition-between-xcodebuild-and-symlink-action-for-test-xcframework
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates when modulemap files are generated XCFramework
with static libraries. Previously, modulemap were generated after
the XCFramework bundle was created with xcodebuild. Now, it's being
included as part of the headers directory.
Additionally, this change adopts the intermediates module ahead of a
rule migration to test/starlark_tests/.
PiperOrigin-RevId: 465638790
(cherry picked from commit e3cd464)