Add support for swiftinterface files from (xc)frameworks file processing #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally we chose not to take this upstream commit because we want to maintain support for pre-compiling your own internal frameworks without library evolution. Due to future commits on the upstream branch that we do want this commit takes swiftinterface only support while still maintaining swiftmodule support (cherry picked from commit 6c85e96)
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins,
thii and
mattrobmattrob
as code owners
keith
referenced
this pull request
Aug 11, 2023
This moves `.swiftmodule` files to be ignored during both framework and XCFrameworks file processing. Leaving only `.swiftinterface` files as the only Swift module file to be used for import rules. PiperOrigin-RevId: 464599149
mattrobmattrob
approved these changes
Aug 11, 2023
keith
deleted the
ks/add-support-for-swiftinterface-files-from-xc-frameworks-file-processing
branch
chiragramani
pushed a commit
to uber-common/rules_apple
that referenced
this pull request
Aug 11, 2023
…ing (bazelbuild#2043) Originally we chose not to take this upstream commit because we want to maintain support for pre-compiling your own internal frameworks without library evolution. Due to future commits on the upstream branch that we do want this commit takes swiftinterface only support while still maintaining swiftmodule support (cherry picked from commit 6c85e96) Co-authored-by: Mauricio Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally we chose not to take this upstream commit because we want to
maintain support for pre-compiling your own internal frameworks without
library evolution. Due to future commits on the upstream branch that we
do want this commit takes swiftinterface only support while still
maintaining swiftmodule support
(cherry picked from commit 6c85e96)