Add support for importing Swift frameworks through Swift interface files #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
referenced
this pull request
Aug 11, 2023
Previously, support for importing Swift based frameworks was limited to Swift interoperability with Objective-C targets through imported Clang module map files. This change adopts recently introduced swift_common API to compile Swift module interface files imported by Apple frameworks. PiperOrigin-RevId: 464877564
|
depends on bazelbuild/rules_swift#1085 and #2044 |
keith
force-pushed
the
ks/add-support-for-importing-swift-frameworks-through-swift-interface-files
branch
from
d3ed7de
to
2e548f3
Compare
Previously, support for importing Swift based frameworks was limited to Swift interoperability with Objective-C targets through imported Clang module map files. This change adopts recently introduced swift_common API to compile Swift module interface files imported by Apple frameworks. PiperOrigin-RevId: 464877564 (cherry picked from commit ede1610)
keith
force-pushed
the
ks/add-support-for-importing-swift-frameworks-through-swift-interface-files
branch
from
2e548f3
to
4812987
Compare
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins,
thii and
mattrobmattrob
as code owners
brentleyjones
approved these changes
Aug 14, 2023
keith
deleted the
ks/add-support-for-importing-swift-frameworks-through-swift-interface-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, support for importing Swift based frameworks was limited
to Swift interoperability with Objective-C targets through imported Clang
module map files. This change adopts recently introduced swift_common
API to compile Swift module interface files imported by Apple frameworks.
PiperOrigin-RevId: 464877564
(cherry picked from commit ede1610)