Little fixes to stop lint warnings (#783)

* Fix some typos, some missing loads and buildifier warnings.
bazelbuild · Nov 13, 2023 · 988ebe8 · 988ebe8
1 parent 9dd0c8c
commit 988ebe8
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/pkg/private/deb/deb.bzl b/pkg/private/deb/deb.bzl
@@ -181,7 +181,7 @@ pkg_deb_impl = rule(
     Create a Debian package.
 
     This rule produces 2 artifacts: a .deb and a .changes file. The DefaultInfo will
-    include both. If you need downstream rule to specificially depend on only the .deb or
+    include both. If you need downstream rule to specifically depend on only the .deb or
     .changes file then you can use `filegroup` to select distinct output groups.
 
     **OutputGroupInfo**

diff --git a/pkg/private/pkg_files.bzl b/pkg/private/pkg_files.bzl
@@ -228,7 +228,7 @@ def _process_pkg_symlink(mapping_context, pkg_symlink_info, origin):
         link_to = pkg_symlink_info.target,
     )
 
-def _process_pkg_filegroup(mapping_context, pkg_filegroup_info, origin):
+def _process_pkg_filegroup(mapping_context, pkg_filegroup_info):
     if hasattr(pkg_filegroup_info, "pkg_dirs"):
         for d in pkg_filegroup_info.pkg_dirs:
             _process_pkg_dirs(mapping_context, d[0], d[1])
@@ -267,7 +267,6 @@ def process_src(mapping_context, src, origin):
         _process_pkg_filegroup(
             mapping_context,
             src[PackageFilegroupInfo],
-            origin,
         )
         found_info = True
     if PackageSymlinkInfo in src:

diff --git a/pkg/private/tar/BUILD b/pkg/private/tar/BUILD
@@ -18,6 +18,10 @@ All interfaces are subject to change at any time.
 
 load("@rules_python//python:defs.bzl", "py_binary", "py_library")
 
+package(
+    default_applicable_licenses = ["//:license"],
+)
+
 licenses(["notice"])
 
 filegroup(

diff --git a/pkg/rpm_pfg.bzl b/pkg/rpm_pfg.bzl
@@ -712,7 +712,7 @@ pkg_rpm = rule(
     Is the equivalent to `%config(missingok, noreplace)` in the `%files` list.
 
     This rule produces 2 artifacts: an .rpm and a .changes file. The DefaultInfo will
-    include both. If you need downstream rule to specificially depend on only the .rpm or
+    include both. If you need downstream rule to specifically depend on only the .rpm or
     .changes file then you can use `filegroup` to select distinct output groups.
 
     **OutputGroupInfo**

diff --git a/tests/tar/BUILD b/tests/tar/BUILD
@@ -14,7 +14,7 @@
 # -*- coding: utf-8 -*-
 """Tests for pkg_tar."""
 
-load("@rules_python//python:defs.bzl", "py_test")
+load("@rules_python//python:defs.bzl", "py_binary", "py_test")
 
 # buildifier: disable=bzl-visibility
 load("//pkg:mappings.bzl", "pkg_attributes", "pkg_files", "pkg_mkdirs", "pkg_mklink")
@@ -577,7 +577,7 @@ pkg_tar(
     symlinks = {
         # We expect package_dir to apply to this
         "tree_artifact/toss_in_another": "some_target",
-        # But we protect the user from duplicationg package_dir in their
+        # But we protect the user from duplicating package_dir in their
         # link. That was the old behavior of symlink.
         "new/base/something/this": "that",
     },