Skip to content

Commit

Permalink
fix(platforms): include flag_values in config_settings (#2236)
Browse files Browse the repository at this point in the history
This function that allows us to generate config settings for
supported platforms did not get the flag_values addition.
  • Loading branch information
aignas authored Sep 22, 2024
1 parent 1d7fd51 commit 93eda70
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ A brief description of the categories of changes:
in extra_requires in py_wheel rule.
* (rules) Prevent pytest from trying run the generated stage2
bootstrap .py file when using {obj}`--bootstrap_impl=script`
* (toolchain) The {bzl:obj}`gen_python_config_settings` has been fixed to include
the flag_values from the platform definitions.


### Added
Expand Down
1 change: 1 addition & 0 deletions python/versions.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -722,5 +722,6 @@ def gen_python_config_settings(name = ""):
for platform in PLATFORMS.keys():
native.config_setting(
name = "{name}{platform}".format(name = name, platform = platform),
flag_values = PLATFORMS[platform].flag_values,
constraint_values = PLATFORMS[platform].compatible_with,
)

0 comments on commit 93eda70

Please sign in to comment.