feat(pypi) Handle local version in requirement parsing #2377
+65
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewianda
commented
Nov 6, 2024
aignas
reviewed
Nov 14, 2024
ewianda
force-pushed
the
feat-pip-parse-handle-local-versions
branch
3 times, most recently
from
69fd075
to
3e05fbf
Compare
ewianda
force-pushed
the
feat-pip-parse-handle-local-versions
branch
from
3e05fbf
to
3002d39
Compare
aignas
reviewed
Nov 16, 2024
| version_start = entry.find("==") | ||
| if version_start != -1: | ||
| # Extract everything after '==' until the next space or end of the string | ||
| version = entry[version_start + 2:].split(" ")[0] |
There was a problem hiding this comment.
nit: I prefer using partition in the code because it just creates three return values.
Suggested change
| version = entry[version_start + 2:].split(" ")[0] | |
| version, _, _ = entry[version_start + 2:].partition(" ") |
Comment on lines
+38
to
+39
|
|
||
| entry: The requirement string. |
There was a problem hiding this comment.
Suggested change
| entry: The requirement string. | |
| Args: | |
| entry: {type}`str` The requirement string. |
Comment on lines
-95
to
+108
| normalize_name(entry[0]): entry | ||
| (entry[0], _extract_version(entry[1])): entry |
There was a problem hiding this comment.
You are dropping the normalize_name here, could we keep it here please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to handle local versions of packages, especially pytorch. With this change, it is possible to have different versions of the same package