fix: keep import path values if Bazel-builtin PyInfo is removed #2415
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
force-pushed
the
fix.missing.builtinpyinfo.erases.imports
branch
from
f16551b
to
ffc3176
Compare
aignas
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The collect_imports() function added import strings from BuiltinPyInfo if it was non-None.
However, operator precedence caused the
if-elseternary to ignore both list comprehensions(one for PyInfo and one for BuiltinPyInfo) if BuiltinPyInfo was None.
To fix, I rewrote the function as a regular for loop to eliminate the ambiguous looking
ternary expression.
Fixes: #2414