Load objc_library from rules_cc.
#1544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adincebic
requested review from
aaronsky,
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
PiperOrigin-RevId: 772948242 (cherry picked from commit e0029ba)
adincebic
force-pushed
the
adin/cherry-pick-e0029bade593fae99fe1cd2ef7938d1a5d2e673a
branch
from
c6b890a to
efdb470
Compare
aaronsky
approved these changes
Jun 25, 2025
Comment on lines
+6
to
+13
| load( | ||
| "//swift:swift_binary.bzl", | ||
| "swift_binary", | ||
| ) | ||
| load( | ||
| "//swift:swift_library.bzl", | ||
| "swift_library", | ||
| ) |
There was a problem hiding this comment.
was this formatting choice needed?
There was a problem hiding this comment.
Yeah, we should only do it to wrap on 80 characters.
There was a problem hiding this comment.
I believe buildifier did it for me.
There was a problem hiding this comment.
Or maybe not, can't recall if buildifier even does that.
There was a problem hiding this comment.
I think it was part of the cherry-pick, since on upstream they have them on separate lines because the path is longer before the copybara.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick e0029bade593fae99fe1cd2ef7938d1a5d2e673a