Skip to content

Use ctx.coverage_instrumented to detect if a target should be instrumented #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

Use ctx.coverage_instrumented to detect if a target should be instrumented #1547

merged 2 commits into from
Jun 27, 2025

Conversation

brentleyjones
Copy link
Collaborator

No description provided.

@brentleyjones
Copy link
Collaborator Author

Not sure if configure_features is the best location for this, but I basically needed a features_for_build_modes that applied at the target level.

@brentleyjones brentleyjones changed the title Use ctx.coverage_instrumented to detect if a file should be instrumented Use ctx.coverage_instrumented to detect if a target should be instrumented Jun 26, 2025
fmeum
fmeum reviewed Jun 26, 2025
View reviewed changes
@brentleyjones @fmeum
Update swift/internal/features.bzl
4cd2a4c 
Co-authored-by: Fabian Meumertzheim <[email protected]>
@brentleyjones brentleyjones enabled auto-merge (squash) June 27, 2025 15:00
@brentleyjones brentleyjones merged commit ccfe585 into master Jun 27, 2025
13 checks passed
@brentleyjones brentleyjones deleted the bj/use-ctx.coverage_instrumented-to-detect-if-a-file-should-be-instrumented branch June 27, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum left review comments

@luispadron luispadron luispadron approved these changes

@aaronsky aaronsky Awaiting requested review from aaronsky aaronsky is a code owner

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brentleyjones @fmeum @luispadron