Improve resolution comment

[kmate-ct]

See #379. This changes the current resolution comment from:

# duplicates in org.threeten:threetenbp downgraded to 1.6.8
# - com.google.cloud:google-cloud-pubsub:1.123.0 wanted version 1.6.5
# - com.google.cloud:google-cloud-storage:2.14.0 wanted version 1.6.3

to:

# duplicates in org.threeten:threetenbp promoted to 1.6.8
# - com.google.cloud:google-cloud-pubsub:1.123.0 wanted version 1.6.5
# - com.google.cloud:google-cloud-storage:2.14.0 wanted version 1.6.3
# - com.google.cloud:google-cloud-storage:2.27.0 (evicted) wanted version 1.6.8

[kmate-ct]

It would actually even better if the resolution comment of com.google.cloud:google-cloud-storage would not be empty, but would state that 2.27.0 was present in the graph, but not chosen because of the fixed version.

[johnynek]

Thanks for this improvement.

Glad the edge label is finally useful! ;)

I had one suggestion if you are willing to take and I would be happy to merge.

[johnynek]

rather than using Boolean can we add to DepsModel.scala something like:

sealed abstract class EvictionState(val isEvicted: Boolean)
object EvictionState {
  case object Evicted extends EvictionState(true)
  case object Retained extends EvictionState(false)
}

so we don't have "boolean blindess" type bugs? I'd rather have Edge[MavenCoordinate, EvictionState]] and e.label.isEvicted

[kmate-ct]

Yep, I thought about that as well, it'd be much better!

However, I'm still concerned that with this fix we're just fixing a side effect of a different normalizer bug, see my latest comment on #379. We could continue the conversation there and if we find that this is indeed the right fix, and not something else, then I'll do the fix you recommended and we can merge, but first it'd be great to make sure. Thanks!