fix: #291 Modify method used to calc estimated stt duration #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamsingreen
approved these changes
Jul 22, 2021
| @@ -7,23 +7,21 @@ const updateDescOrder = (firstTr, secondTr) => { | |||
|
|
|||
| const secondsToDhms = (sec) => { | |||
There was a problem hiding this comment.
Consider changing the name of the function to reflect that it no longer returns days?
| const h = Math.floor((seconds % (3600 * 24)) / 3600); | ||
| const m = Math.floor((seconds % 3600) / 60); | ||
| const s = Math.floor(seconds % 60); | ||
|
|
||
| return [ d, h, m, s ]; | ||
| return [ h, m, s ]; | ||
| }; | ||
|
|
||
| const ToHumanReadable = (sec) => { |
There was a problem hiding this comment.
While we're editing this file consider starting function name w/lower case t?
|
|
||
| return [ dDisplay, hDisplay, mDisplay, sDisplay ].filter(display => display).join(', '); | ||
| return [ hDisplay, mDisplay, sDisplay ].filter(display => display).join(', '); | ||
| }; | ||
|
|
||
| const ToDhmsCompact = (sec) => { |
There was a problem hiding this comment.
Also start w/lower case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
Fixes #291
Describe what the PR does
State whether the PR is ready for review or whether it needs extra work
Ready
Additional context