Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unecessary re-renders #159

Closed
pietrop opened this issue May 15, 2019 · 2 comments
Closed

Unecessary re-renders #159

pietrop opened this issue May 15, 2019 · 2 comments
Assignees
@pietrop
Labels
bug Something isn't working

Comments

@pietrop
Copy link
Contributor

pietrop commented May 15, 2019

Describe the bug
Using Highlighting Component Updates in React Chrome Dev tool, gives some insights on parts of the component that might be re-rendering unnecessarily.

Possibly linked to issue #150

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Demo app'
  2. Click on 'Load Demo'
  3. open React dev tools, click on settings, and check box for 'highlight updates'
  4. click 'play' btn
  5. See colours hilights

Expected behavior

Fewer re-renders, and no re-render for components not involved in the playback (eg ToolTip)

Screenshots

performance-issue

Desktop (please complete the following information):

  • OS:OSX 10.13.6
  • Browser Chrome 74.0.3729.131
  • Version 1.0.2

Additional context
@pietrop pietrop added the bug Something isn't working label May 15, 2019
@pietrop pietrop self-assigned this May 15, 2019
@pietrop pietrop pinned this issue May 15, 2019
@pietrop pietrop mentioned this issue May 15, 2019
Closed
@pietrop
Copy link
Contributor Author

pietrop commented May 15, 2019 •
edited
Loading

Explored in branch PR/Branch #160

performance-issue-solution

Seem to have found a way to reduce unnecessary re-renders using should component update 🚀

see how, "how does it work" btn doesn't re-render compared to previous gif

@pietrop
Copy link
Contributor Author

pietrop commented Aug 12, 2019

addressed in #160 and currently in #175 soon to be merged into master, so closing for now

@pietrop pietrop closed this as completed Aug 12, 2019
@pietrop pietrop unpinned this issue Aug 13, 2019
@pietrop pietrop mentioned this issue Sep 17, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pietrop pietrop

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pietrop