-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding test to timed text editor #193
base: master
Are you sure you want to change the base?
Conversation
You might want to check this change against this issue #159 (which is the reason why it was initially separated into its own component) see #160 for more details. TL;DR: using react inspector tool |
facebook/react#16437 (comment) The original highlighting function has disappeared but instead you can use the profiler to record the rendering. |
Is your Pull Request request related to another issue in this repository ?
Not from this issue, but DPE has a dependency on react-transcript-editor and we want to start adding tests to it.
bbc/digital-paper-edit-electron#4
Describe what the PR does
Adding the most basic test to timed-text-editor and also removing CustomEditor because it's a wrapper component for one single function - we don't really need it.
State whether the PR is ready for review or whether it needs extra work
Ready
Additional context