Upgrades cookie dependency for CVE-2024-47764 #12041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
approved these changes
Oct 11, 2024
HarveyPeachey
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA N/A
Overall changes
I had to force resolutions for now as Express has a fixed dependency on cookie 0.6.0. Express fix their issue in a later version and it looks like they just upgrade cookie with no changes in their codebase: expressjs/express#6029
Ideally we want to bring Express up to the latest version but this a is a bigger change.
Testing
Should be sufficiently covered by automated tests
Helpful Links
Coding Standards
Repository use guidelines