Emotion upgrade #12366
Draft
Emotion upgrade #12366
+333
−3,144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoore108
commented
Feb 5, 2025
| @@ -7,7 +7,7 @@ import GlobalStyles from './global-styles'; | |||
| * Revisit snapshot mechanism following Emotion migration. | |||
| */ | |||
|
|
|||
| describe('global-styles', () => { | |||
| describe.skip('global-styles', () => { | |||
There was a problem hiding this comment.
Will try to avoid doing this.
The <GlobalStyles /> is getting rendered when used locally:
just seems to be a change in how emotion/jest works with this update that causes these snapshots to return nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA [number]
Overall changes
workerIdleMemoryLimitproperty to Jest configs to ensure workers are cleaned up during test runs to prevent memory leaks: https://jestjs.io/docs/configuration#workeridlememorylimit-numberstringCode changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines