Read more button poc #12563
Open
Read more button poc #12563
+616
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad-more-button-poc
…ad-more-button-poc
…the chosen services
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LilyL0u
commented
Mar 26, 2025
pvaliani
reviewed
Apr 11, 2025
amoore108
reviewed
Apr 11, 2025
| <button | ||
| css={[buttonStyle, styles.hideButtonOnDesktop]} | ||
| type="button" | ||
| onMouseDown={handleEvent} |
There was a problem hiding this comment.
Just for context on why these event handlers were used instead of onClick.
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus#notes
We want to show a focus indicator on the revealed element after the button is clicked/tapped/keyed. onClick didn't behave this way as focus was lost after clicking the button.
pvaliani
reviewed
Apr 11, 2025
pvaliani
reviewed
Apr 11, 2025
pvaliani
reviewed
Apr 11, 2025
amoore108
approved these changes
Apr 11, 2025
louisearchibald
approved these changes
Apr 11, 2025
pvaliani
approved these changes
Apr 15, 2025
dasvensklave
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://jira.dev.bbc.co.uk/browse/WORLDSERVICE-505
A11y and screenreader requirements: https://paper.dropbox.com/doc/Article-Continue-Reading-button-a11y-screen-reader-UX--CjmSUEpk7TxVMR4HWApmH8HGAg-LZvihgQf7tXdezcUfP1ZB
Summary
Two variations on the now named 'Continue Reading' button are created. They are one component, with conditionally different styling. The functionality is the same for both variations.
Currently the variations are hard coded to be available on Pidgin and Urdu for variation A and Mundo and Arabic for variation B. This will be removed for the experiment. You can view the component on pages by changing
continueReadingEnabled = false,to true in ArticlePage.tsx, and making the page smaller than desktop size. You can view the component on storybook.The component only shows on mobile widths.
When you click the button it moves the focus to the newly revealed paragraph, including a custom focus indicator. This also happens when navigating on keyboard or tapping on mobile.
Some pages have a lite site CTA under the headline which adds to the count of the blocks above the button. This is why we have a check for the lite site CTA being enabled: to see whether we need to add one to our count of where to put the button. The button should appear after 3 paragraphs.
Code changes
Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links