Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Not include errors below threshold #507

Open
mramitanand opened this issue Jan 31, 2017 · 1 comment
Open

[Feature request] Not include errors below threshold #507

mramitanand opened this issue Jan 31, 2017 · 1 comment

Comments

@mramitanand
Copy link

mramitanand commented Jan 31, 2017

HI I guess this is more a feature request if possible? I have set threshold on runs for any pages with errors above 10% which works great - when it finishes its run it shows a report on screen of the pages that have errors above 10 but when it generates the gallery, it also includes the pages that errors below 10% in shots dir/gallery.html. Is there anyway to exclude those with less than 10% from being included? Thanks

Addition: Also not to include anything below threshold into the thumbnails gallery directory this just takes up space.

@ChrisBAshton
Copy link
Contributor

ChrisBAshton commented Feb 1, 2017

Hmm, we have:

#Choose how results are displayed, by default alphanumeric. Different screen widths are always grouped.​#alphanumeric - all paths (with, and without, a difference) are shown, sorted by path​#diffs_first - all paths (with, and without, a difference) are shown, sorted by difference size (largest first)​#diffs_only - only paths with a difference are shown, sorted by difference size (largest first)​
mode: diffs_first

Sounds like you would like a diffs_above_threshold option for mode. This isn't implemented yet, but we would be happy to review a PR!

@mramitanand mramitanand changed the title Not include errors below threshold [Feature request] Not include errors below threshold Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants