Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for publishing #5

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Fix CI for publishing #5

merged 1 commit into from
Jan 25, 2025

Conversation

chris-zen
Copy link
Collaborator

@chris-zen chris-zen commented Sep 7, 2024

This PR provides the following novelties:

  • Using pyproject.toml
  • Support for uv
  • Supporting cython in the build
  • A Makefile with common development tasks (checking code, building packages and docker, publishing packages and docker, ...)
  • Producing and publishing packages for all the supported python versions (3.8, 3.9, 3.10, 3.11) and platforms (linux, macos)

@chris-zen chris-zen force-pushed the fix-ci-publish branch 27 times, most recently from 37f4e85 to 628fece Compare January 12, 2025 10:29
Copy link
Member

@FedericaBrando FedericaBrando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I just spot a typo in the make that I've commented. :)

thanks a lot! 😄

@FedericaBrando
Copy link
Member

FedericaBrando commented Jan 13, 2025

I was checking the README.md and this part is not contained in the Makefile:

oncodrivefml/README.md

Lines 84 to 90 in 628fece

```bash
git clone [email protected]:bbglab/oncodrivefml.git
cd oncodrivefml
make install-dev
source .venv/bin/activate
oncodrivefml --help
```

while in the Makefile the install-dev is not present. How would the readme change in this case?

@chris-zen
Copy link
Collaborator Author

I was checking the README.md and this part is not contained in the Makefile:

oncodrivefml/README.md

Lines 84 to 90 in 628fece

```bash
git clone [email protected]:bbglab/oncodrivefml.git
cd oncodrivefml
make install-dev
source .venv/bin/activate
oncodrivefml --help
```

while in the Makefile the install-dev is not present. How would the readme change in this case?

Fixed. Added build-dev to the Makefile and updated the README.md

@chris-zen chris-zen marked this pull request as ready for review January 25, 2025 11:38
@chris-zen chris-zen merged commit 3bdecde into master Jan 25, 2025
9 checks passed
@chris-zen chris-zen deleted the fix-ci-publish branch January 25, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants