This repository has been archived by the owner on Apr 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
1.0 dev #10
Open
Sherlcok
wants to merge
404
commits into
bbhoss:master
Choose a base branch
from
abrasive:1.0-dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1.0 dev #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed up Makefile
This fixes systems where IPv6 is available in libraries but just not enabled in the kernel.
Fallback to IPv4 if IPv6 is not present
…rnings on OpenBSD Rearrange includes to fix warnings thrown on OpenBSD 4.9/i386
…s, and changed the loop to fetch mac adresses for each player
Previously the number of players would be detected as one regardless of number of players.
Support older versions of libao
Fix power-on sequence
the reader thread (manifested as an initial "stutter" before the buffer filled adequately)
Fix somewhat racy initial playback
shairport just yet.
Configurable start buffer size
Updated Makefile
Fix situation where ipv6 address is actually ipv4 address
this doesn't fix #34 though -- this should still be added, i.e. some automatic fallback to just any random free port.
pthread seems to reuse thread identifiers (at least on arm). Reset it to zero after closing a playing connection, or else future thread might believe they are playing.
Reset playing_thread on connection close. Fixes #217
Certain senders (AirAudio for Android for example) periodically send SET_PARAMETER requests with Content-Length: 0, to which shairport responds with an error, making those apps misbehave.
Allow empty SET_PARAMETER request
This can happen during a shutdown triggered by the playing thread. Fixes issue #233 reported by therealmuffin.
We use the mutex's state to determine whether the playing_thread is valid or not. Also now use pthread_equal, as we should. Should address issue #236.
Under some circumstances, RTSP responses would be split into multiple packets. This causes Airfoil to barf, as it interprets the end of the packet as the end of the response. Since TCP_CORK is not portable, this fix buffers the packet on the stack before using a single write. This fixes issue #213.
Add avahi as a start dependency, fix the provide line. Also add a note about updating the logrotate file if non-standard log and error files are used.
mDNS is now handled more or less in the same way audio is. Multiple mDNS backends are available, shairport tries them all until one works. This makes it, IMHO, cleaner, and easier to add other mDNS backends in the future, such as using tinysvcmdns or dns-sd library. Also it will also allow to define mDNS backends as plugins, in a similar way it is done in PR #230.
Add this option to the system-v init script.
This backend allows shairport to run without having a heavy daemon such as avahi or mDNSResponder running in the background. ipv6 support is more or less experimental right now.
This backend uses mDNSResponder, like the external-dns-sd one. However, this one uses the dns-sd library instead of relying on an external program.
Avahi provides (sometimes at least) a dns_sd compatibility layer. There's no point using it if we can use avahi's "native" library, so don't even detect dns_sd.h's availability
bash-ism snuck into a nominally POSIX-compliant script
SIGUSR1 is used to interrupt calls and shut down cleanly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.