iOS V8: remove the dependency on BrowserEngineKit

Bug introduced by: https://chromium.googlesource.com/v8/v8.git/+/7dec59784535eac97053729969a42282ce1387b6 Fixes #164
bblanchon · Apr 30, 2024 · 8905f25 · 8905f25
1 parent 3bab942
commit 8905f25
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/patches/ios/v8.patch b/patches/ios/v8.patch
@@ -0,0 +1,14 @@
+diff --git a/BUILD.gn b/BUILD.gn
+index d905b219a22..1610f1adae9 100644
+--- a/BUILD.gn
++++ b/BUILD.gn
+@@ -4753,9 +4753,6 @@ v8_header_set("v8_internal_headers") {
+   }
+
+   frameworks = []
+-  if (is_ios) {
+-    frameworks += [ "BrowserEngineKit.framework" ]
+-  }
+
+   public_deps = [
+     ":torque_runtime_support",
diff --git a/steps/03-patch.sh b/steps/03-patch.sh
@@ -19,6 +19,7 @@ case "$OS" in
 
   ios)
     git apply -v "$PATCHES/ios/pdfium.patch"
+    [ "${PDFium_ENABLE_V8:-}" == "true" ] && git -C v8 apply -v "$PATCHES/ios/v8.patch"
     ;;
 
   wasm)
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,6 +19,7 @@ case "$OS" in @@
       ios)
         git apply -v "$PATCHES/ios/pdfium.patch"
+        [ "${PDFium_ENABLE_V8:-}" == "true" ] && git -C v8 apply -v "$PATCHES/ios/v8.patch"
         ;;
       wasm)
@@ Expand Down @@