Skip to content

Commit

Permalink
Remove Makefile kludge, do it rightly in glide.* files
Browse files Browse the repository at this point in the history
  • Loading branch information
Juanjo Alvarez committed Jul 26, 2017
1 parent 10a940c commit a03e9e9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 12 deletions.
11 changes: 1 addition & 10 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -117,18 +117,9 @@ test-coverage-internal:
fi; \
done;

build: dependencies zombies-fix docker-build
build: dependencies docker-build
$(DOCKER_RUN) -v $(GOPATH):/go $(DOCKER_BUILD_IMAGE) make build-internal

# Fix for https://github.com/opencontainers/runc/issues/1443; remove this kludge
# when PR #1506 has been merged into ~master
TMPGIT := $(shell mktemp -d)
zombies-fix:
git clone https://github.com/LittleLightLittleFire/runc.git $(TMPGIT)/repo; \
cd $(TMPGIT)/repo && git rebase origin/1443-runc-reap-child-process; \
rm -rf $(VENDOR_PATH)/github.com/opencontainers/runc/; \
cp -a $(TMPGIT)/repo $(VENDOR_PATH)/github.com/opencontainers/runc

build-internal:
mkdir -p $(BUILD_PATH); \
for cmd in $(COMMANDS); do \
Expand Down
3 changes: 2 additions & 1 deletion glide.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion glide.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,11 @@ import:
version: ^1.0.0-rc7
subpackages:
- specs-go/v1
# This version has a fix for the zombie problem with runc; restore this
# dependency to the opencontainers repos once merged
- package: github.com/opencontainers/runc
version: ^1.0.0-rc3
repo: https://github.com/LittleLightLittleFire/runc.git
version: 0d21c2183e3908caff242fe298592b6cc4bf361b
subpackages:
- libcontainer
- libcontainer/configs
Expand Down

0 comments on commit a03e9e9

Please sign in to comment.