WIP: Add an interface for AdvancedProjection of fields. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the mode argument of FFTPower to be an AdvancedProjection object, which does allows changing the basis of the Power/XI field, with inner product operators.
This is slower than bin counting, but it allows easier extension to other basis where binning is not the right thing to do.
The plan is to implement ProjectFFTPower algorithm with these Projection objects.
I do not quite like the names of things. These concepts are very similar to the 'spaces' concept defined in nifty, so perhaps some ideas can be borrowed from there?