Allow configuration of default properties of blosc compressor. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear Patric, |
This was referenced May 22, 2023
|
Re-opened as zarr-developers#6 |
|
Hi everyone! 👋🏻 I've posted an update. Please see my comment → #41 (comment). Thank you @pedson, @joshmoore and @SabineEmbacher. Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to allow the user to set the number of threads used for blosc decompression on the auto-created
Compressorobjects during read operations.This is done via
CompressorFactory.BloscCompressor.defaultProperties.put("nthreads", 8);This was the least invasive/modifying approach I could find (in conjunction with PR #41 for user defined compressor objects). However, it does expose the actual
BloscCompressorclass and the implementation of the map. I'd be happy to implement something more extensive keeps the class implementation private if the maintainers prefer.I also only updated the
nthreadsproperty to pull from thedefaultPropertiesmap rather than the default constants. If this approach is acceptable, I can change the other properties to have the same behavior.