Sanitize boolean conversions in signature subpackets. #1575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a
PrimaryUserID
packet whose boolean value is encoded as an invalid, but non-zero value (e.g.2
) is interpreted astrue
.I believe, BC should detect this invalid value as the sign that something went wrong and instead throw an exception.
This PR introduces the
Bytes
utility class in the core module, which contains two methods for converting between byte arrays and booleans.Especially the
fromByteArray()
is more strict in that it does not allow arrays with a length other than 1 and also does not allow byte values other than 0 and 1.