Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
PGPSignature.join()
to retain the signature packet length encoding format of the base signature. Previously, the merged result signature object would have its packet length format forced toLEGACY
, no matter what the input signatures were encoded with. This would result in mismatches when doing comparisons between encodings in PGPainless' tests.PGPSignatureSubpacketGenerator.addEmbeddedSignature()
to retrieve the encoding of the embedded signature in legacy format. Otherwise, signatures using the new packet length encoding format, which might have a different header length would result in broken embedded sigs, since the wrong number of header bytes would be cut stripped off.Note: These changes are currently still part of #1911