Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3845 - Student: FT: Other financial support questions #4350

Merged

Conversation

lewischen-aot
Copy link
Collaborator

@lewischen-aot lewischen-aot commented Feb 12, 2025

  • Revised title from "Other financial support" to the following:

Other financial support and targeted resources

  • Create a sub header with the following text below the header:

"Funding you will receive to help meet specific educational costs towards your education during this study period."

  • Put the questions in the following order and current functionality remains the same

Will you receive government funding (e.g., EI training allowance, social assistance payments intended to cover education-related costs?
Will you receive non-government (private sector) funding (e.g. employer)?
Will you receive voluntary contributions from parent(s)/step-parent/sponsor/legal guardian?

  • Created new category named: "Financial support" and placed it above the "Other financial support" category
  • Added the following question from the "Other financial support" category.

Will you receive merit-based scholarships or need-based bursaries, including provincial government scholarships received during your study period?
Will you receive B.C. income assistance for persons with disabilities that you will be receiving under the Employment and Assistance for Persons with Disabilities Act during your study period?

Screenshot
image

@lewischen-aot lewischen-aot self-assigned this Feb 12, 2025
@lewischen-aot lewischen-aot changed the title #3845 #3845 - Student: FT: Other financial support questions Feb 12, 2025
@lewischen-aot lewischen-aot added Question Further information is requested User Story Student Student Features Form.io Form IO definitions changed. labels Feb 12, 2025
@lewischen-aot lewischen-aot marked this pull request as ready for review February 12, 2025 23:15
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, the new category looks ok, just had a question, are we changing the content for a few questions and, if yes, are they aligned with the ACs?

@guru-aot guru-aot self-requested a review February 13, 2025 16:27
@guru-aot
Copy link
Collaborator

Can you please verify the order of the questions as asked by the AC?
image

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.11% ( 3914 / 17704 )
Methods: 9.96% ( 226 / 2268 )
Lines: 25.46% ( 3380 / 13276 )
Branches: 14.26% ( 308 / 2160 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

@lewischen-aot
Copy link
Collaborator Author

Nice work, the new category looks ok, just had a question, are we changing the content for a few questions and, if yes, are they aligned with the ACs?

Confirmed with the business team and updated the questions to align with the AC's questions.

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 87.58% ( 1418 / 1619 )
Methods: 84.66% ( 160 / 189 )
Lines: 89.72% ( 1170 / 1304 )
Branches: 69.84% ( 88 / 126 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 69.95% ( 6282 / 8981 )
Methods: 67.39% ( 773 / 1147 )
Lines: 73.7% ( 4907 / 6658 )
Branches: 51.19% ( 602 / 1176 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking further on the content part, look good 👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @lewischen-aot

@lewischen-aot lewischen-aot deleted the feature/#3845-student-ft-other-financial-support-questions branch February 13, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed. Question Further information is requested Student Student Features User Story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants