Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3930 - FT Self Report Parent Income #4356

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Conversation

guru-aot
Copy link
Collaborator

@guru-aot guru-aot commented Feb 14, 2025

Supporting users Key Supporting users Consolidated Variable Name 2025-2026 Program Year Key 2025-2026 Program Year Consolidated Variable Name Remaining Years Key Remaining Years Consolidated Variable Name
foreignAssets parent1NetAssests, parent2NetAssests studentParentsNetAssests studentDataStudentParentNetAssests studentParentsNetAssests studentDataStudentParentNetAssests
parentalContributions parent1Contributions, parent2Contributions studentParentsNetContribution studentDataStudentParentNetContribution studentParentsNetContribution studentDataStudentParentNetContribution
totalIncome parent1TotalIncome, parent2TotalIncome studentParentsTotalIncome studentDataStudentParentsTotalIncome studentParentsTotalIncome studentDataStudentParentsTotalIncome
totalIncomeTaxLine43500 parent1Tax, parent2Tax studentParentsTotalIncomeTaxLine43500 studentDataStudentParentsTotalIncomeTaxLine43500 null null
cppLine30800 parent1CppEmployment, parent2CppEmployment studentParentsCppLine30800 studentDataStudentParentsCppLine30800 null null
cppLine31000 parent1CppSelfemploymentOther, parent2CppSelfemploymentOther studentParentsCppLine31000 studentDataStudentParentsCppLine31000 null null
eiLine31200 parent1Ei, paren2Ei studentParentsEiLine31200 studentDataStudentParentsEiLine31200 null null

@guru-aot guru-aot self-assigned this Feb 14, 2025
@guru-aot guru-aot added Form.io Form IO definitions changed. Camunda Worflow Involves camunda workflow changes labels Feb 14, 2025
@guru-aot guru-aot marked this pull request as ready for review February 14, 2025 00:36
@dheepak-aot dheepak-aot self-requested a review February 14, 2025 01:20
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!. Looks good 👍

Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for adapting the keys to the new changes.

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.11% ( 3914 / 17704 )
Methods: 9.96% ( 226 / 2268 )
Lines: 25.46% ( 3380 / 13276 )
Branches: 14.26% ( 308 / 2160 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 87.58% ( 1418 / 1619 )
Methods: 84.66% ( 160 / 189 )
Lines: 89.72% ( 1170 / 1304 )
Branches: 69.84% ( 88 / 126 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 69.95% ( 6282 / 8981 )
Methods: 67.39% ( 773 / 1147 )
Lines: 73.7% ( 4907 / 6658 )
Branches: 51.19% ( 602 / 1176 )

Copy link
Collaborator

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @guru-aot

@guru-aot guru-aot added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 7ca2e2e Feb 14, 2025
21 checks passed
@guru-aot guru-aot deleted the #3930_FT_Self_Report_Parent_Income branch February 14, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Camunda Worflow Involves camunda workflow changes Form.io Form IO definitions changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants