CMS-572: Add FeatureIcon component #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Note that for wilderness camping, the icon path we get from Strapi is |
update class and variable names for clarity
duncan-oxd
force-pushed
the
CMS-572-icons
branch
from
8d3447c to
ed7d4ac
Compare
|
Change icon name from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
CMS-572
Description
Added a component to resolve the
featureType.namestring from Strapi to a local svg path to display the icon. It involved a big map but I think it's fine. The dev server will pre-import all of the files, but in production I think it will just populate the img src so the icons will be loaded on demand.I also renamed some classnames and variables for clarity.