New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: kc gold integration #2135

Merged

dleard merged 35 commits into develop from feat/kc-gold-integration

Jan 19, 2023

Contributor

pbastia commented Jan 11, 2023

No description provided.

pbastia force-pushed the feat/kc-gold-integration branch 2 times, most recently from c8792a0 to 2b981ae Compare

January 16, 2023 22:09

pbastia commented

View reviewed changes

app/pages/_app.tsx Show resolved Hide resolved

pbastia commented

View reviewed changes

schema/deploy/2022_01_16_keycloak_gold_reject_all_organisation_membership.sql

+              -- As we migrate to keycloak gold, we reject all ciip_user_organisation permissions,
+              -- to ensure user accounts don't inherit someone else's access permissions (on the odd chance of a changed email address).
+              update ggircs_portal.ciip_user_organisation set status='rejected';

Contributor Author

pbastia Jan 18, 2023

be clear when we deploy to prod, communicate with business area

pbastia commented

View reviewed changes

schema/deploy/tables/ciip_user.sql Outdated Show resolved Hide resolved

pbastia commented

View reviewed changes

schema/deploy/tables/ciip_user.sql Outdated Show resolved Hide resolved

pbastia commented

View reviewed changes

schema/deploy/types/jwt_token.sql Outdated

		@@ -3,30 +3,6 @@

		begin;

Contributor Author

pbastia Jan 18, 2023

This should also be a 001 migration for the same reason as above

pbastia commented

View reviewed changes

schema/test/unit/tables/ciip_user_test.sql Outdated Show resolved Hide resolved

pbastia commented

View reviewed changes

schema/verify/tables/ciip_user.sql Outdated Show resolved Hide resolved

pbastia and others added 21 commits

January 18, 2023 16:34


          refactor: jwt_token type has a sub of type text

1fa7c55


          refactor: trigger to disallow user update under certain conditions

7173bb3


          refactor: revert functions

3b27c65


          refactor: rename immutable flag function

0ab3acf


          refactor: dropping policies before changing the uuid type

5c1b55a


          refactor: ciip_user table with a uuid of type text

f4dc142


          refactor: updating set_user_id trigger with text type for uuid

19dbdac


          refactor: update_timestamps doesnt depend on a uuid type

dc2fa04


          refactor: re-adding the policies removed before the change

58dd768


          refactor: session middleware

105a0e1


          chore: updating nodejs

c928859


          refactor: using sso-express to login with the new kc gold instance

b8125df


          test: update tests for cif_user table

2220fed


          refactor: removing obsolete registration buttons

1f2e626


          chore: removing default create_user mutation

7154fec


          refactor: custom create user mutation that reconciles users

e96dd1e


          refactor: user form calls the custom mutation

125c2c4


          test: frontend test updates

8eeb8a1


          test: starting to write tests for the create user mutation

0c0311e


          refactor: rejecting all accepted or pending access requests

4b23b58


          test: testing mutation adding or updating user upon login

8d79130

pbastia added 14 commits

January 18, 2023 16:36


          test: testing the update uuid function

692d334


          test: updating login page e2e

21b9800


          chore: pre-commit

0230ea2


          test: e2e redirects

96e9e40


          fix: session idled message is not displayed when user tries to login

f94bc6d


          refactor: sqitch verify

68b086e


          chore: flagging false positive in env example file

c2c7d76


          chore: eslint fixes and removing unused dependencies

a1bd298


          chore: schema files


          chore: pre-commit errors

a7bf7a2


          chore: removing sqitch verify after db deploy in ci

506f429


          chore: removing unnecessary permissions

2756ea9


          chore: reworks are now migrations

0f4c2fc


          chore: yarn lockfile after rebase

pbastia force-pushed the feat/kc-gold-integration branch from 6e582ec to 8769427 Compare

January 19, 2023 00:38

dleard approved these changes

View reviewed changes

Contributor

dleard left a comment

💯 Awesome! Looks good to me.
Things I checked:

Non-idempotent sqitch changes were made to follow our numbered migration format
I was able to log in to the app
My user was created in the db using the idir guid and email address from kc
My user was updated in the db using the idir guid and email address from kc (after I manually changed my uuid and reset the can update flag to true)

dleard merged commit aef6348 into develop

dleard deleted the feat/kc-gold-integration branch

January 19, 2023 18:52

bc-cas-shipit bot temporarily deployed to dev

January 19, 2023 19:10

Inactive

bc-cas-shipit bot had a problem deploying to test

January 24, 2023 23:32

Failure

bc-cas-shipit bot temporarily deployed to test

January 25, 2023 00:25

Inactive

bc-cas-shipit bot had a problem deploying to prod

January 28, 2023 00:37

Failure

bc-cas-shipit bot temporarily deployed to prod

January 28, 2023 03:43

Inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet