Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/change reg purpose frontend/2169 #2771

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

andrea-williams
Copy link
Contributor

@andrea-williams andrea-williams commented Jan 31, 2025

Notes on Brianna's additions:

  • The errors @andrea-williams was encountering were related to mocking. Even though the mocks were set up correctly, vitest wasn't picking them up (logged them in the code and they came out as real functions instead of spys). Vitest can be touchy about mocking the same file/function more than once, and I think our two fetchFormEnums helpers (one in admin, one in reg) were colliding with each other
  • To address ^, I moved all the mocks that were used in fetchFormEnums to the shared bciers mocks/global files
  • I also combined the two separate fetchFormEnums into a single function in the shared bciers file. The admin/reg returned different mock values, so I added an App arg so I could keep the different mock values without refactoring any tests

@andrea-williams andrea-williams force-pushed the task/change-reg-purpose-frontend/2169 branch 9 times, most recently from 67d81d5 to b7edd00 Compare February 7, 2025 01:04
@andrea-williams andrea-williams force-pushed the task/change-reg-purpose-frontend/2169 branch 2 times, most recently from 8dfa441 to 9daf76c Compare February 11, 2025 16:39
@BCerki BCerki force-pushed the task/change-reg-purpose-frontend/2169 branch 3 times, most recently from 996c781 to 90a7891 Compare February 12, 2025 00:05
@BCerki BCerki force-pushed the task/change-reg-purpose-frontend/2169 branch from 90a7891 to e5d558f Compare February 12, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants