Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GWELLS-2048] BUG FIX** Display Licences in Well Summary #2073

Merged
merged 4 commits into from
Dec 5, 2023
Merged

[GWELLS-2048] BUG FIX** Display Licences in Well Summary #2073

merged 4 commits into from
Dec 5, 2023

Conversation

LocalNewsTV
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • refactored code to get licence numbers for a given well. Old code was externally sourced and no longer working
  • created WellLicence model since none existed to link to table.
  • made well summary licence numbers scalable to multiple licences (from singular)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LocalNewsTV LocalNewsTV merged commit 44d801b into release Dec 5, 2023
10 checks passed
@LocalNewsTV LocalNewsTV deleted the gwells-2048-display-licences-in-summary branch December 5, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidclaveau davidclaveau davidclaveau approved these changes

Assignees
No one assigned
Labels
Backend Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LocalNewsTV @davidclaveau @bcgov-csnr-cd