Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GWELLS-2055] FEATURE** Search by licences #2075

Merged
merged 3 commits into from
Dec 12, 2023
Merged

[GWELLS-2055] FEATURE** Search by licences #2075

merged 3 commits into from
Dec 12, 2023

Conversation

LocalNewsTV
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Add search parameter to lookup wells with a specific licence
  • add new optional table column to Search results to display licence numbers

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LocalNewsTV LocalNewsTV requested review from dmitri-korin-bcps and a team December 6, 2023 17:10
fergmac
fergmac reviewed Dec 12, 2023
View reviewed changes
app/backend/wells/serializers_v2.py
)
def get_licence_number(self, obj):
with connection.cursor() as cursor:
licence_num_query = """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking for context on why we are using raw SQL here? I understand there are situations where routing around the model layer and using raw SQL is necessary.

@LocalNewsTV LocalNewsTV merged commit 04e4a52 into release Dec 12, 2023
10 checks passed
@LocalNewsTV LocalNewsTV deleted the gwells-2055-searchable-licenses branch December 12, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fergmac fergmac fergmac left review comments

@davidclaveau davidclaveau davidclaveau approved these changes

@dmitri-korin-bcps dmitri-korin-bcps Awaiting requested review from dmitri-korin-bcps

Assignees
No one assigned
Labels
Backend Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LocalNewsTV @fergmac @davidclaveau @bcgov-csnr-cd