Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX][GWELLS-2070]** maintain aquifer data regardless of changes, prevent overwrite #2080

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[HOTFIX][GWELLS-2070]** maintain aquifer data regardless of changes, prevent overwrite #2080

merged 1 commit into from
Dec 12, 2023

Conversation

davidclaveau
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Simple (but temporary) hotfix to prevent Pumping Test data from being overwritten
  • aquifer_parameters_set is not skipped so data is maintained when updating other fields (preventing being overwritten)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@davidclaveau davidclaveau marked this pull request as ready for review December 12, 2023 16:54
@davidclaveau davidclaveau merged commit 1229308 into release Dec 12, 2023
10 checks passed
@davidclaveau davidclaveau deleted the hotfix/overwriting-pump-tests branch December 12, 2023 16:55
@davidclaveau davidclaveau linked an issue Dec 12, 2023 that may be closed by this pull request
Data/Rows overwrote by new entries under "Pumping Test Information and Aquifer Parameters" #2070
Closed
@davidclaveau davidclaveau mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalNewsTV LocalNewsTV LocalNewsTV approved these changes

Assignees
No one assigned
Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data/Rows overwrote by new entries under "Pumping Test Information and Aquifer Parameters"
3 participants
@davidclaveau @LocalNewsTV @bcgov-csnr-cd