Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE][GWELLS-#2053] changed hex colour values for hydraulic wells to be more visible #2084

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[FEATURE][GWELLS-#2053] changed hex colour values for hydraulic wells to be more visible #2084

merged 1 commit into from
Dec 18, 2023

Conversation

acatchpole
Copy link
Contributor

@acatchpole acatchpole commented Dec 15, 2023 •
edited
Loading

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • changed the hex value for the halo (stroke) of wells with hydraulic properties from #e29200 to #5dfa57. Values changed in:
    app\frontend\src\common\assets\images\wells-hydraulic.svg
    app\frontend\src\common\mapbox\layers.js

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@acatchpole acatchpole marked this pull request as ready for review December 18, 2023 16:41
@acatchpole acatchpole merged commit 01eeb86 into release Dec 18, 2023
9 checks passed
@acatchpole acatchpole deleted the change-well-halo branch December 18, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidclaveau davidclaveau davidclaveau approved these changes

@sanjaytkbabu sanjaytkbabu sanjaytkbabu approved these changes

@LocalNewsTV LocalNewsTV Awaiting requested review from LocalNewsTV

Assignees
No one assigned
Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acatchpole @davidclaveau @sanjaytkbabu @bcgov-csnr-cd