Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX][GWELLS-2052] Added empty string check #2101

Merged
merged 1 commit into from
Jan 4, 2024
Merged

[HOTFIX][GWELLS-2052] Added empty string check #2101

merged 1 commit into from
Jan 4, 2024

Conversation

sanjaytkbabu
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Added empty string check to filter out the empty values of hydraulic conductivity

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

acatchpole
acatchpole approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@acatchpole acatchpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is effective at fixing an edge case bug.

@sanjaytkbabu sanjaytkbabu merged commit 4091c2c into release Jan 4, 2024
9 checks passed
@sanjaytkbabu sanjaytkbabu deleted the feat/gwells-2052 branch January 4, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatchpole acatchpole acatchpole approved these changes

Assignees
No one assigned
Labels
Backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanjaytkbabu @acatchpole @bcgov-csnr-cd