Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG FIX][GWELLS-2104] Refactor get licence number method #2107

Merged
merged 2 commits into from
Jan 11, 2024
Merged

[BUG FIX][GWELLS-2104] Refactor get licence number method #2107

merged 2 commits into from
Jan 11, 2024

Conversation

fergmac
Copy link
Contributor

@fergmac fergmac commented Jan 11, 2024 •
edited
Loading

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • I currently cannot reproduce the issue locally:
  • I refactored the get licence number method to use the model layer rather than using raw SQL
    Screen Shot 2024-01-10 at 4 09 24 PM

@fergmac fergmac self-assigned this Jan 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fergmac fergmac merged commit 4b288b6 into release Jan 11, 2024
9 checks passed
@fergmac fergmac deleted the gwells-2104-licence-numbers-repeating branch January 11, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalNewsTV LocalNewsTV LocalNewsTV approved these changes

Assignees

@fergmac fergmac

Labels
Backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fergmac @LocalNewsTV @bcgov-csnr-cd