-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE][GWELLS-2094] Address autofill/autocomplete added to Well Owner and Well Location forms #2111
Conversation
…not yet populate fields other than Street address
…ddress field focus
…l selection is made
… element. also removed some testing log statements
…vince and city is available
Pipeline Checks Failures: The API tests that failed on the first run, succeeded when re-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall Thoughts
- I would use
our
API as a proxy to the geocoder api (new endpoint), and set the geocoder api as an environment variable. Doing so achieves the following:- Removes power from the frontend of the app, preserving it in the backend where we control it
- having it as an
env
variable lets us update the url in the event the architecture changes, without having to do an app rebuild, or open a PR. - The api advertises API keys available for production apps like ours, and if that came gets implemented, we would be able to protect that with our API with significantly less overhaul in the future.
- Can use the existing APIService Class that exists in Vue, and simplify the codebase further by reusing code
- Good practice
- fetchAddressSuggestions could be moved into a class or a utilities folder, doing so would reduce complexity in this file, and be more reusable in the application
app/frontend/src/submissions/components/SubmissionForm/Owner.vue
Outdated
Show resolved
Hide resolved
app/frontend/src/submissions/components/SubmissionForm/Location.vue
Outdated
Show resolved
Hide resolved
app/frontend/src/submissions/components/SubmissionForm/Owner.vue
Outdated
Show resolved
Hide resolved
app/frontend/src/submissions/components/SubmissionForm/Owner.vue
Outdated
Show resolved
Hide resolved
app/frontend/src/submissions/components/SubmissionForm/Owner.vue
Outdated
Show resolved
Hide resolved
app/frontend/src/submissions/components/SubmissionForm/Owner.vue
Outdated
Show resolved
Hide resolved
app/frontend/src/submissions/components/SubmissionForm/Owner.vue
Outdated
Show resolved
Hide resolved
app/frontend/src/submissions/components/SubmissionForm/Owner.vue
Outdated
Show resolved
Hide resolved
app/frontend/src/submissions/components/SubmissionForm/Location.vue
Outdated
Show resolved
Hide resolved
app/frontend/src/submissions/components/SubmissionForm/Owner.vue
Outdated
Show resolved
Hide resolved
app/frontend/src/submissions/components/SubmissionForm/Owner.vue
Outdated
Show resolved
Hide resolved
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 2 New issues |
Pull Request Standards
HOTFIX
,FEATURE
,etc
][GWELLS-###]
README
,functions
,team documents
]Description
This PR includes the following proposed change(s):
Utilized the BC Gov Geocoder API to get addresses. This API allows 1000 requests/min so no throttling should occur. BUT, it does not have Postal Code information, so Postal Code is not auto-filled.