Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][GWELLS-2104] Return unique licence numbers #2131

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

fergmac
Copy link
Contributor

@fergmac fergmac commented Feb 1, 2024

…eturned unique.

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • To replicate the issue seen in staging and production I have updated the aquifers fixture JSON to include a water rights licence with multiple purposes. Specifically another water rights licence with the same licence number but a different purpose.
  • Updated the well list serializer to return only unique licence numbers.

After replicating but before fix:
Screenshot 2024-01-31 at 4 21 47 PM

After bug fix:
Screenshot 2024-02-01 at 1 07 59 PM

@fergmac fergmac self-assigned this Feb 1, 2024
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The evil is defeated

@fergmac fergmac linked an issue Feb 1, 2024 that may be closed by this pull request
@fergmac fergmac merged commit 58e4518 into release Feb 1, 2024
9 checks passed
@fergmac fergmac deleted the gwells-2104-licence-number-repeating branch February 1, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Licence numbers repeating in table instead of displaying all values
3 participants