Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gwells/2212pid dashes #2273

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Gwells/2212pid dashes #2273

merged 4 commits into from
Jul 24, 2024

Conversation

lunamoonmoon
Copy link
Contributor

@lunamoonmoon lunamoonmoon commented Jul 11, 2024

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

On the submit report page you can now enter the parcel identifier with dashes and it will be saved without dashes.

This PR includes the following proposed change(s):

  • for pid number dashes are valid input for entry
  • for pid number dashes are not saved to the database
  • for pid number although it is now a text entry instead of number it still throws an error when characters other than dashes and numbers are entered
  • Before changes: Screenshot 2024-07-11 at 8 20 28 AM
  • After changes: Screenshot 2024-07-11 at 8 22 57 AM
  • Displays with dashes but saves to database without Screenshot 2024-07-11 at 8 24 15 AM
  • Characters other than dashes and numbers throws an error Screenshot 2024-07-11 at 8 46 21 AM

@lunamoonmoon lunamoonmoon reopened this Jul 24, 2024
@lunamoonmoon lunamoonmoon merged commit 6867fd1 into release Jul 24, 2024
12 checks passed
@lunamoonmoon lunamoonmoon deleted the GWELLS/2212pid-dashes branch July 24, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants