Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependancy on indy-sdk for testing #109

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Remove dependancy on indy-sdk for testing #109

wants to merge 11 commits into from

Conversation

Gavinok
Copy link
Contributor

@Gavinok Gavinok commented Mar 12, 2025

This PR resolves #70 by removing the dependency on indy-sdk. In addition, this allows us to update the python version used in tails and testing to 3.12

@Gavinok Gavinok requested review from esune and WadeBarnes and removed request for esune March 12, 2025 22:46
WadeBarnes
WadeBarnes requested changes Mar 13, 2025
View reviewed changes
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to rebase your changes on the latest from main. If you look at the commit history on your PR and compare that to the commit history on main you'll see some of the same commits with different commit hashes.

esune
esune reviewed Mar 13, 2025
View reviewed changes
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, once the open comment is resolved we can merge.

Gavinok added 11 commits March 13, 2025 11:10
@Gavinok
Removed the need for setup.py and migrate to pyproject.toml
ed7bc1e 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
Correct build error and more explicit module and config in pyproject.…
fcd1fd7 
…toml

Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
Upgraded python version to 3.12
9b8542a 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
Initial conversion from indy-sdk (tests failing)
f5dd1f7 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
removed indy-sdk and got tests passing
d6aef49 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
Update dependencies and simplify test code
256f03b 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
minor code clean up and remove redundant functions
2600009 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
remove outdated comment
6341d1e 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
formatting
eaea9fa 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
Fixed unclosed sessions error when running tests
8fc143c 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok
Cleaned up Dockerfiles
d2cdec8 
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok Gavinok requested a review from WadeBarnes March 13, 2025 18:26
@WadeBarnes
Copy link
Member

Still seeing duplicate commits
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esune esune esune left review comments

@WadeBarnes WadeBarnes Awaiting requested review from WadeBarnes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency on indy-sdk
3 participants
@Gavinok @WadeBarnes @esune