-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize local dev env setup #4
Conversation
- modified the build-web-dev - updated vue config to enable hot-reloading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @ronaldo-macapobre!
A few recommendations.
- Add the launch.json changes to the dev container configuration so it's always there for everyone by default.
- Have the build always build all project containers. This avoids having to make specific updates to the script.
- Update the the
./manage
script to add adebug
command that would start the set of containers for hot reloading and debugging, where thestart
command would start the compiled runtime set of containers. This avoids having to edit the./manage
script to access the different features.
Regarding the line ending issues. You could add some additional lines to cover affected files to this file to ensure the line endings are always set as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
One item that might be worth noting in the documentation. The dev container will fail to build if you are connected to the BC Government VPN when building/rebuilding. |
- updated ./manage to include start-debug and build-debug - updated README.md content
@WadeBarnes I tried suggestion 3. to build everything ( |
- Simplify build - Simplify commands - Restore use of getStartupParams Signed-off-by: Wade Barnes <[email protected]>
- Relabel from `scv` and `scjscv` to `jasper`. Signed-off-by: Wade Barnes <[email protected]>
- to reflect updates to the `./manage` script. Signed-off-by: Wade Barnes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ronaldo-macapobre, Looking good!
I've added a few commits:
- To further cleanup the
./manage
script and restore some functionality that was lost in the shuffle. - To relabel the images and routes from
scv
tojasper
. - To update the development environment documentation based on the above changes.
Let me know what you think. If you're happy with the updates we can merge the PR.
- Allows the dev container to share the host's docker instance, allowing the host to see any containers launched in the dev container. Signed-off-by: Wade Barnes <[email protected]>
- changed host.docker.interal to container name
- We missed switching a couple local folder mounts over to using `LOCAL_WORKSPACE_FOLDER`. Signed-off-by: Wade Barnes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's got it. Great work @ronaldo-macapobre
Pull Request for JIRA Ticket: 10
Issue ticket number and link
https://jag.gov.bc.ca/jira/browse/JASPER-10
Description
vue.config.js
is necessary to avoid proxy error issues and does not affect the behavior of the old workflow whereweb
artifact is used.Type of change
How Has This Been Tested?
Test Configuration:
If applicable
Checklist:
Documentation References
N/A