Initial Infra Code Changes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 23, 2024 23:17
- Minor refactoring for naming convention and code formatting
- Added tags
- changed task def to use web - added variables for web and api images
- Renamed web task definition
- Enabled public ip
- Ensure ECS is accessed from LB only
- Adjusted ecs resources - Renamed stuff
WadeBarnes
approved these changes
Aug 1, 2024
added 3 commits
August 1, 2024 19:23
- Added backend tfvars
ronaldo-macapobre
temporarily deployed
to
sandbox
GitHub Actions
Inactive
- Added initial documentation
Initial README.md file added. |
Thank-you! |
|
I've been reviewing as changes have been made. I'll defer to @amlanc1 for final review and approval. |
amlanc1
requested changes
Aug 6, 2024
| @@ -0,0 +1,5 @@ | |||
| app_name = "jasper" | |||
| environment = "dev" | |||
| kms_key_name = "jasper-kms-key" | |||
There was a problem hiding this comment.
Can we change reading these variables from environment variables instead of files? Some of the values may be sensitive and we dont want storing them in files in repo. What we can do is, set environment variables or secrets on Github repo then read those here. Any terraform variables need to be in format TF_VAR_name
…riable from Github.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for JIRA Ticket: JASPER-44
Issue ticket number and link
https://jag.gov.bc.ca/jira/browse/JASPER-44
Description
Code changes based from the initial AWS Architecture diagram. Includes the following:
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Deployed to Quartech's AWS Sandbox account