Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce unique names ADO 2223 #64

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

JohYoshidaBCGov
Copy link
Collaborator

What changes did you make?

Enforced uniqueness of names for Fields, Groups, and Select Options (at the front-end level). Also made name, label, and (in the case of Select Options) values searchable in the view table, which will help identify any existing duplicated names

Why did you make these changes?

Implementing https://dev.azure.com/BC-SDPR/Forms%20Modernization/_workitems/edit/2223

What alternatives did you consider?

Considered adding validation to the database, but frontend is sufficient and avoids any potential errors with any existing duplicates, which can be safely caught fixed manually

Checklist

  • I have assigned at least one reviewer
  • My code meets the style guide
  • My code has adequate test coverage (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant