-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pidp 1002/1098 add user notification for reasons cards are inaccessible #611
Open
AdityaMantripragada
wants to merge
20
commits into
develop
Choose a base branch
from
Pidp-1002-Add-user-notification-for-reasons-cards-are-inaccessible-
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−15
Open
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
495a6fe
windows scroll console error fix
AdityaMantripragada 5f9e416
multiple dialog box fix
AdityaMantripragada 0285780
toastservice added to access request cards
AdityaMantripragada ca89ab5
disabled card modified
AdityaMantripragada 2a0a3a9
closeToast service added
AdityaMantripragada 0d61db2
remove unrelated commits from 1002
AdityaMantripragada 6a7f09d
removed unused import
AdityaMantripragada 3872a7e
Merge branch 'develop' into Pidp-1002-Add-user-notification-for-reaso…
AdityaMantripragada d697977
moved to constants
AdityaMantripragada 50d3d0f
Merge branch 'develop' into Pidp-1002-Add-user-notification-for-reaso…
AdityaMantripragada ae04a22
Merge branch 'develop' into Pidp-1002-Add-user-notification-for-reaso…
AdityaMantripragada 240b14f
resasons added to profilestatus
AdityaMantripragada b4ee1e5
Merge branch 'Pidp-1002-Add-user-notification-for-reasons-cards-are-i…
AdityaMantripragada 2494271
updated the constants
AdityaMantripragada e74a413
Merge branch 'develop' into Pidp-1002-Add-user-notification-for-reaso…
AdityaMantripragada 3d8563d
Merge branch 'develop' of https://github.com/bcgov/moh-pidp into Pidp…
AdityaMantripragada ad44b4b
Merge branch 'develop' into Pidp-1002-Add-user-notification-for-reaso…
AdityaMantripragada c48c64b
added constants file
AdityaMantripragada e732bdd
Merge branch 'Pidp-1002-Add-user-notification-for-reasons-cards-are-i…
AdityaMantripragada debc6a7
Merge branch 'develop' into Pidp-1002-Add-user-notification-for-reaso…
AdityaMantripragada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ import { Component, EventEmitter, Input, Output } from '@angular/core'; | |
import { FaIconComponent } from '@fortawesome/angular-fontawesome'; | ||
import { IconProp } from '@fortawesome/fontawesome-svg-core'; | ||
import { faFileLines } from '@fortawesome/free-solid-svg-icons'; | ||
import { ToastService } from '@app/core/services/toast.service'; | ||
|
||
import { | ||
InjectViewportCssClassDirective, | ||
|
@@ -31,12 +32,30 @@ export class AccessRequestCardComponent { | |
@Input() public completed?: boolean; | ||
public faFileLines = faFileLines; | ||
|
||
public constructor() { | ||
public constructor(private toastService: ToastService) { | ||
this.icon = faFileLines; | ||
this.action = new EventEmitter<void>(); | ||
} | ||
|
||
public onAction(): void { | ||
this.action.emit(); | ||
if ( | ||
this.actionDisabled && | ||
this.heading === 'Driver Fitness Practitioner Portal' | ||
) { | ||
this.toastService.openInfoToast( | ||
'Insufficient college licensing to request enrolment.', | ||
'close', | ||
{ duration: 100000, panelClass: 'close-icon' }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as previous. duration can be kept in constants. |
||
); | ||
} else if (this.actionDisabled) { | ||
this.toastService.openInfoToast( | ||
'Incorrect credential type being used to request enrolment.', | ||
'close', | ||
{ duration: 100000, panelClass: 'close-icon' }, | ||
); | ||
} else { | ||
this.toastService.closeToast(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In which case it will be called ? |
||
this.action.emit(); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep these error messages in constants and use them here.