fix render loop bug

bcgov · Jan 3, 2025 · 8eff85a · 8eff85a
1 parent df46bea
commit 8eff85a
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 13 deletions.
diff --git a/frontend/package-lock.json b/frontend/package-lock.json
diff --git a/frontend/package.json b/frontend/package.json
@@ -73,7 +73,7 @@
     "pure-react-carousel": "^1.30.1",
     "react": "^18.2.0",
     "react-bootstrap": "^2.7.4",
-    "react-bootstrap-typeahead": "^6.3.2",
+    "react-bootstrap-typeahead": "^6.3.4",
     "react-chartjs-2": "^5.2.0",
     "react-collapsed": "^4.0.2",
     "react-collapsible": "^2.10.0",

diff --git a/frontend/src/app/components/containers/complaints/details/complaint-details-edit.tsx b/frontend/src/app/components/containers/complaints/details/complaint-details-edit.tsx
@@ -1,4 +1,4 @@
-import { FC, useEffect, useState } from "react";
+import { FC, useEffect, useState, useCallback } from "react";
 import { useAppDispatch, useAppSelector } from "@hooks/hooks";
 import { bcUtmZoneNumbers, getSelectedOfficer, formatLatLongCoordinate } from "@common/methods";
 import { Coordinates } from "@apptypes/app/coordinate-type";
@@ -184,9 +184,12 @@ export const ComplaintDetailsEdit: FC = () => {
 
   const [complaintAttachmentCount, setComplaintAttachmentCount] = useState<number>(0);
 
-  const handleSlideCountChange = (count: number) => {
-    setComplaintAttachmentCount(count);
-  };
+  const handleSlideCountChange = useCallback(
+    (count: number) => {
+      setComplaintAttachmentCount(count);
+    },
+    [setComplaintAttachmentCount],
+  );
 
   //-- use effects
   useEffect(() => {

diff --git a/frontend/src/app/components/containers/complaints/outcomes/outcome-attachments.tsx b/frontend/src/app/components/containers/complaints/outcomes/outcome-attachments.tsx
@@ -1,4 +1,4 @@
-import { FC, useEffect, useState } from "react";
+import { FC, useCallback, useEffect, useState } from "react";
 import { AttachmentsCarousel } from "@components/common/attachments-carousel";
 import { COMSObject } from "@apptypes/coms/object";
 import { handleAddAttachments, handleDeleteAttachments, handlePersistAttachments } from "@common/attachment-utils";
@@ -75,9 +75,12 @@ export const OutcomeAttachments: FC<props> = ({ showAddButton = false }) => {
     }
   }, [carouselData, showAddButton]);
 
-  const handleSlideCountChange = (count: number) => {
-    setOutcomeAttachmentCount(count);
-  };
+  const handleSlideCountChange = useCallback(
+    (count: number) => {
+      setOutcomeAttachmentCount(count);
+    },
+    [setOutcomeAttachmentCount],
+  );
 
   const saveButtonClick = async () => {
     //initial state when there is no attachments