fix: CE-1198-Cannot add animal after emptied drugs

[joshgamache]

Addresses bug CE-1198. A type error was flagging when drugs were added, then removed, from an animal outcome. Additional refactoring is also included in this.

Changes 🚧

• Modified save validation with optional chaining to ensure undefined rather than error.
• Refactored getValue ➡️ getDropdownOption used for dropdown options to operate as a common method.

How Has This Been Tested? 🔬

• Manual testing, matching from issue report.

To test 🔬

1. In a complaint outcome, add an outcome by animal
2. Add a drug to the outcome, then delete it.
3. Save the outcome. If there are validation errors, you should get a toast saying as such, not a full-page error. If there are no validation errors, it should save.

Checklist 📃

• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

---

Thanks for the PR!

Deployments, as required, will be available below:

• Frontend
• Backend

Please create PRs in draft mode. Mark as ready to enable:

• Analysis Workflow

After merge, new images are deployed in:

• Merge Workflow

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.9% Duplication on New Code

See analysis details on SonarQube Cloud