Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CE-1103 / CE-1273 CE-1274 #781

Closed
wants to merge 4 commits into from
Closed

chore: CE-1103 / CE-1273 CE-1274 #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f1773c
update things
nayr974 Nov 29, 2024
96cc3be
Update drug-authorized-by.tsx
nayr974 Nov 29, 2024
90e3630
remove references
nayr974 Nov 29, 2024
56416cb
Update package.json
nayr974 Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12,554 changes: 5,917 additions & 6,637 deletions frontend/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

21 changes: 14 additions & 7 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "0.28.1",
"private": true,
"dependencies": {
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
"@craco/craco": "^7.1.0",
"@craco/types": "^7.1.0",
"@faker-js/faker": "^8.0.2",
Expand Down Expand Up @@ -37,7 +38,7 @@
"@typescript-eslint/parser": "5.56.0",
"assert": "^2.1.0",
"axios": "^1.7.0",
"bootstrap": "^5.2.3",
"bootstrap": "^5.3.3",
"bootstrap-icons": "^1.10.5",
"chart.js": "^4.3.0",
"child_process": "^1.0.2",
Expand All @@ -63,7 +64,7 @@
"lodash": "^4.17.21",
"make-fetch-happen": "11.0.3",
"node": "^21.6.1",
"npm": "^9.8.1",
"npm": "^10.9.1",
"nrs-ce-common-types": "^1.0.10",
"omggif": "^1.0.10",
"os-browserify": "^0.3.0",
Expand Down Expand Up @@ -122,7 +123,7 @@
"url": "https://github.com/bcgov/nr-compliance-enforcement/issues"
},
"scripts": {
"lint": "./node_modules/.bin/eslint",
"lint": "eslint src --ext .js,.jsx,.ts,.tsx",
"start": "craco start",
"build": "craco build",
"test": "craco test",
Expand Down Expand Up @@ -156,12 +157,12 @@
"cy-verify-downloads": "^0.2.4",
"cypress": "^13.6.1",
"cypress-delete-downloads-folder": "^0.0.5",
"eslint": "^8.24.0",
"eslint": "^8.57.1",
"eslint-config-airbnb": "19.0.4",
"eslint-config-airbnb-typescript": "^17.0.0",
"eslint-config-standard-with-typescript": "^34.0.0",
"eslint-plugin-import": "2.27.5",
"eslint-plugin-jsdoc": "^40.0.0",
"eslint-plugin-jsdoc": "^50.6.0",
"eslint-plugin-jsx-a11y": "6.7.1",
"eslint-plugin-n": "^15.0.0",
"eslint-plugin-promise": "^6.0.0",
Expand All @@ -171,12 +172,18 @@
"playwright-webkit": "^1.27.1",
"prettier": "^3.0.3",
"rollup": "^3.29.5",
"sass": "^1.62.1",
"sass": "1.77.6",
"ts-jest": "^29.1.0",
"typescript": "^5.0.4"
},
"peerDependencies": {
"postcss": "^8.4.49"
},
"overrides": {
"typescript": "^5.0.4"
"typescript": "^5.0.4",
"nth-check": "^2.1.1",
"resolve-url-loader": "^5.0.0",
"sass-loader": "^16.0.3"
},
"browser": {
"fs": false,
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/common/validation-checkbox-group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const ValidationCheckboxGroup: FC<ValidationCheckboxGroupProps> = ({

useEffect(() => {
setCheckedItems(checkedValues);
}, [checkedValues.length]);
}, [checkedValues]);

return (
<div id="checkbox-div">
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/common/validation-phone-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const ValidationPhoneInput: FC<ValidationPhoneInputProps> = ({
international,
}) => {
const errClass = errMsg === "" ? "" : "error-message";
const calulatedClass = errMsg === "" ? "comp-form-control" : "comp-form-control" + " error-border";
const calulatedClass = errMsg === "" ? "comp-form-control" : "comp-form-control error-border";
return (
<div>
<div className={className}>
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/app/components/common/attachments-carousel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export const AttachmentsCarousel: FC<Props> = ({
if (complaintIdentifier) {
dispatch(getAttachments(complaintIdentifier, attachmentType));
}
}, [complaintIdentifier, dispatch]);
}, [attachmentType, complaintIdentifier, dispatch]);

//-- when the component unmounts clear the attachments from redux
useEffect(() => {
Expand All @@ -82,15 +82,15 @@ export const AttachmentsCarousel: FC<Props> = ({
if (typeof onSlideCountChange === "function") {
onSlideCountChange(slides.length);
}
}, [slides.length]);
}, [onSlideCountChange, slides.length]);

// Clear all pending upload attachments
useEffect(() => {
if (cancelPendingUpload) {
setSlides([]);
if (setCancelPendingUpload) setCancelPendingUpload(false); //reset cancelPendingUpload
}
}, [cancelPendingUpload]);
}, [cancelPendingUpload, setCancelPendingUpload]);

function sortAttachmentsByName(comsObjects: COMSObject[]): COMSObject[] {
// Create a copy of the array using slice() or spread syntax
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/components/common/bc-geocoder-autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const BCGeocoderAutocomplete: FC<Props> = ({ value, id, maxResults, paren
if (inputValue) {
fetchAddresses(inputValue);
}
}, [inputValue, maxResults]);
}, [complaintLocation, dispatch, inputValue, maxResults]);

return (
<CreatableSelect
Expand Down
Loading
Loading